Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(llc): mark unread feature - core #1880

Merged
merged 10 commits into from
Mar 27, 2024
Merged

Conversation

Brazol
Copy link
Contributor

@Brazol Brazol commented Mar 12, 2024

Submit a pull request

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

core functionality of marking messages in channels as unread

@Brazol Brazol changed the title feat: mark unread feature - core feat(core): mark unread feature - core Mar 12, 2024
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 15.38462% with 44 lines in your changes are missing coverage. Please review.

Project coverage is 59.28%. Comparing base (6e58645) to head (2c27ad0).

Files Patch % Lines
packages/stream_chat/lib/src/client/channel.dart 14.70% 29 Missing ⚠️
...ackages/stream_chat/lib/src/core/models/event.dart 0.00% 7 Missing ⚠️
...ages/stream_chat/lib/src/core/api/channel_api.dart 0.00% 5 Missing ⚠️
packages/stream_chat/lib/src/client/client.dart 0.00% 2 Missing ⚠️
packages/stream_chat/lib/src/core/models/read.dart 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1880      +/-   ##
==========================================
- Coverage   59.41%   59.28%   -0.13%     
==========================================
  Files         310      310              
  Lines       17837    17889      +52     
==========================================
+ Hits        10597    10605       +8     
- Misses       7240     7284      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Brazol Brazol changed the title feat(core): mark unread feature - core feat(llc): mark unread feature - core Mar 12, 2024
Copy link
Contributor

@esarbanis esarbanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to add this feature in our documentaion.

packages/stream_chat/lib/src/event_type.dart Show resolved Hide resolved
Copy link
Contributor

@esarbanis esarbanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@esarbanis esarbanis merged commit f9bab6d into master Mar 27, 2024
14 of 16 checks passed
@esarbanis esarbanis deleted the feat/mark-unread-feature branch March 27, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants