Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): mark unread feature - UI #1881

Merged
merged 17 commits into from
Apr 2, 2024
Merged

Conversation

Brazol
Copy link
Contributor

@Brazol Brazol commented Mar 12, 2024

Submit a pull request

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

The UI part of mark as unread feature with "Mark Unread" action and unread indicator

@Brazol Brazol changed the title feat(ui) - mark unread feature - UI feat(ui): mark unread feature - UI Mar 12, 2024
Copy link
Contributor

@esarbanis esarbanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add the new components in our documentation

esarbanis
esarbanis previously approved these changes Mar 27, 2024
Copy link
Contributor

@esarbanis esarbanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Brazol Brazol marked this pull request as ready for review March 27, 2024 12:16
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 61.53846% with 70 lines in your changes are missing coverage. Please review.

Project coverage is 59.84%. Comparing base (305986c) to head (47a92e2).

Files Patch % Lines
...r/lib/src/message_list_view/message_list_view.dart 41.83% 57 Missing ⚠️
...flutter/lib/src/message_widget/message_widget.dart 0.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1881      +/-   ##
==========================================
+ Coverage   59.28%   59.84%   +0.55%     
==========================================
  Files         310      311       +1     
  Lines       17889    18036     +147     
==========================================
+ Hits        10605    10793     +188     
+ Misses       7284     7243      -41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@esarbanis esarbanis force-pushed the feat/mark-unread-feature-ui branch 2 times, most recently from 04e7746 to 23be021 Compare April 2, 2024 14:12
@esarbanis esarbanis force-pushed the feat/mark-unread-feature-ui branch from 23be021 to 47a92e2 Compare April 2, 2024 14:15
Copy link
Contributor

@esarbanis esarbanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@esarbanis esarbanis merged commit 573f4f2 into master Apr 2, 2024
16 checks passed
@esarbanis esarbanis deleted the feat/mark-unread-feature-ui branch April 2, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants