Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): voice recording attachment builder #1907

Merged
merged 4 commits into from May 10, 2024
Merged

Conversation

esarbanis
Copy link
Collaborator

Submit a pull request

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

Adds the ability to play voice recording attachments in the message widget.

@esarbanis esarbanis changed the title feat(llc,ui): voice recording attachment builder feat(ui): voice recording attachment builder Apr 26, 2024
@esarbanis esarbanis marked this pull request as ready for review May 9, 2024 14:16
Copy link

codecov bot commented May 9, 2024

Codecov Report

Attention: Patch coverage is 76.83486% with 101 lines in your changes are missing coverage. Please review.

Project coverage is 60.24%. Comparing base (ca92ee0) to head (6c59c66).

Files Patch % Lines
..._flutter/lib/src/theme/voice_attachment_theme.dart 61.47% 47 Missing ⚠️
...achment_builder/stream_voice_recording_player.dart 74.62% 34 Missing ⚠️
...achment_builder/stream_voice_recording_slider.dart 83.90% 14 Missing ⚠️
...nt_builder/stream_voice_recording_list_player.dart 95.34% 2 Missing ⚠️
...eam_chat_flutter/lib/src/misc/stream_svg_icon.dart 0.00% 2 Missing ⚠️
.../attachment/builder/attachment_widget_builder.dart 0.00% 1 Missing ⚠️
...nt_builder/voice_recording_attachment_builder.dart 95.23% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1907      +/-   ##
==========================================
+ Coverage   59.84%   60.24%   +0.40%     
==========================================
  Files         311      317       +6     
  Lines       18036    18472     +436     
==========================================
+ Hits        10793    11128     +335     
- Misses       7243     7344     +101     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Brazol Brazol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@esarbanis esarbanis merged commit 27cbb03 into master May 10, 2024
16 checks passed
@esarbanis esarbanis deleted the feat/voice_attachment branch May 10, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants