Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): fixes copying a message with mentions #1945

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Conversation

deven98
Copy link
Contributor

@deven98 deven98 commented Jun 11, 2024

Fixes #1929

Currently copying a message does not replace the mentioned IDs with user names. This PR uses the same logic from the package that fixes this in the message text to fix it.

@deven98 deven98 requested a review from Brazol June 11, 2024 12:15
Copy link
Contributor

@Brazol Brazol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 60.23%. Comparing base (e3423d3) to head (bcc2b84).

Files Patch % Lines
...flutter/lib/src/message_widget/message_widget.dart 0.00% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1945      +/-   ##
==========================================
- Coverage   60.28%   60.23%   -0.05%     
==========================================
  Files         317      317              
  Lines       18479    18493      +14     
==========================================
  Hits        11140    11140              
- Misses       7339     7353      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deven98 deven98 merged commit b8d3822 into master Jun 11, 2024
14 of 16 checks passed
@deven98 deven98 deleted the fix/mentions-copy branch June 11, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy message with mention has id instead of name
2 participants