Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix/attachments #24

Merged
merged 7 commits into from
Apr 10, 2020
Merged

Hotfix/attachments #24

merged 7 commits into from
Apr 10, 2020

Conversation

imtoori
Copy link
Contributor

@imtoori imtoori commented Apr 10, 2020 •
edited
Loading

  • Fix video aspect ratio
  • Add property to decide whether to enable video fullscreen
  • Add property to hide the attachment button
  • Do not show send button if an attachment is still uploading
  • Unfocus and disable the TextField before opening the camera (workaround for [image_picker] IOS. Form field under camera overlay stays clickable. flutter/flutter#42417)
  • Add gesture (vertical drag down) to close the keyboard
  • Add keyboard type parameters (set it to TextInputType.text to show the submit button that will even close the keyboard)

The property showVideoFullScreen was added mainly because of this issue fluttercommunity/chewie#261

This was linked to issues Apr 10, 2020
Keyboard opens on top of camera view #18
Closed
No way to hide keyboard #22
Closed
App freezes after taking a photo #20
Closed
@imtoori
Copy link
Contributor Author

imtoori commented Apr 10, 2020

It should close #20
There was a bug opening the camera twice nad with the keyboard #18 bug it was really confusing

@imtoori imtoori linked an issue Apr 10, 2020 that may be closed by this pull request
App crashes when trying to hit send before video finishes processing #19
Closed
@imtoori imtoori linked an issue Apr 10, 2020 that may be closed by this pull request
Need a way to disable the attachments button #23
Closed
@imtoori imtoori linked an issue Apr 10, 2020 that may be closed by this pull request
Videos show wide stretched #21
Closed
@imtoori imtoori added bug Something isn't working enhancement New feature or request labels Apr 10, 2020
@imtoori imtoori merged commit b010371 into master Apr 10, 2020
@delete-merged-branch delete-merged-branch bot deleted the hotfix/attachments branch April 10, 2020 09:44
@isaiahtaylorhh
Copy link

Thank you for such a rapid response on these items!

@rubenvereecken rubenvereecken mentioned this pull request Apr 22, 2021
Closed
6 tasks
@poqueque poqueque mentioned this pull request Jun 17, 2021
Closed
2 tasks
@jagged91 jagged91 mentioned this pull request Jul 9, 2021
Closed
6 tasks
@kalptech2021 kalptech2021 mentioned this pull request May 29, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@imtoori @isaiahtaylorhh