Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added onUserAvatarTap #40

Merged
merged 3 commits into from
Apr 24, 2020
Merged

Conversation

nosmirck
Copy link
Contributor

@nosmirck nosmirck commented Apr 23, 2020

Submit a pull request

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

Added onUserAvatarTap for MessageWidget and MessagesListView

@imtoori
Copy link
Contributor

imtoori commented Apr 23, 2020

I think it's better to move the GestureDetector in the UserAvatar widget, like the ChannelImage
What do you think?

@imtoori imtoori added the enhancement New feature or request label Apr 23, 2020
@imtoori imtoori self-assigned this Apr 23, 2020
@nosmirck
Copy link
Contributor Author

I think it's better to move the GestureDetector in the UserAvatar widget, like the ChannelImage
What do you think?

Sure, what should I do?

@imtoori
Copy link
Contributor

imtoori commented Apr 23, 2020

Just move the gesture detector to UserAvatar and add the property also there passing onUserAvatarTap to UserAvatar

@nosmirck
Copy link
Contributor Author

@imtoori done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants