Pass in SendMessageResponse to onMessageSent callback, instead of mos… #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tly empty Message object
|
Hi @kriztoph thanks a lot for the pr! It will be available in the next release of the SDK 👍 |
6 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tly empty Message object.
When a message is sent, there's a callback called
onMessageSent; right now it passes in theMessageobject before it's sent, so if we do something like modify the message in a presend hook, we have no way to get the message response and check for something like an error type. This change passes in theMessageobject that is returned from the API.Submit a pull request
CLA
Description of the pull request