Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comment out notification handling code on ios due to incompatible dependencies #93

Merged
merged 1 commit into from
Oct 5, 2020

Conversation

imtoori
Copy link
Contributor

@imtoori imtoori commented Oct 5, 2020

Submit a pull request

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

The solution for saving notification details in the offline storage does not work anymore because the Swift SDK cannot be used in Notification extensions.
While waiting for another solution we comment out the implementation so that we can compile the sample app.

@imtoori imtoori marked this pull request as ready for review October 5, 2020 08:06
@imtoori imtoori merged commit 6ddc7d8 into master Oct 5, 2020
@delete-merged-branch delete-merged-branch bot deleted the hotfix/iosExampleApp branch October 5, 2020 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants