Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make unblockMessage method public #1165

Merged
merged 1 commit into from
Sep 4, 2023
Merged

feat: make unblockMessage method public #1165

merged 1 commit into from
Sep 4, 2023

Conversation

gumuz
Copy link
Contributor

@gumuz gumuz commented Sep 4, 2023

made _unblockMessage method public and kept alias for backwards compatibility

@gumuz gumuz changed the title [MOD-940] make unblockMessage method public feat: make unblockMessage method public Sep 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

Size Change: +47 B (0%)

Total Size: 318 kB

Filename Size Change
dist/browser.es.js 69.6 kB +10 B (0%)
dist/browser.full-bundle.min.js 37.6 kB +10 B (0%)
dist/browser.js 70.5 kB +9 B (0%)
dist/index.es.js 69.6 kB +10 B (0%)
dist/index.js 70.6 kB +8 B (0%)

compressed-size-action

@khushal87
Copy link
Member

Implementation wise this looks good. Can you brief me about the purpose behind the change? Thanks 😄

@gumuz
Copy link
Contributor Author

gumuz commented Sep 4, 2023

thanks @khushal87 this was a method that was previously used only internally by the dashboard that we now want to expose to the user. Hence the rename and dropping of the @public marker, I've left the _unblockMessage alias there for backwards compatibility.

@gumuz gumuz merged commit 3cd9a7d into master Sep 4, 2023
6 of 7 checks passed
@gumuz gumuz deleted the public-unblock branch September 4, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants