Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CHAT-1270] ignore shadowed messages in unread count #475

Merged
merged 4 commits into from Oct 26, 2020
Merged

[CHAT-1270] ignore shadowed messages in unread count #475

merged 4 commits into from Oct 26, 2020

Conversation

gumuz
Copy link
Contributor

@gumuz gumuz commented Oct 23, 2020 •
edited

make Channel.countUnread() ignore shadowed messages

@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2020 •
edited

Size Change: +190 B (0%)

Total Size: 199 kB

Filename Size Change
dist/browser.es.js 42.2 kB +40 B (0%)
dist/browser.full-bundle.min.js 28.7 kB +32 B (0%)
dist/browser.js 42.7 kB +40 B (0%)
dist/index.es.js 42.2 kB +38 B (0%)
dist/index.js 42.8 kB +40 B (0%)

compressed-size-action

mahboubii
mahboubii suggested changes Oct 23, 2020
View reviewed changes
Copy link
Contributor

@mahboubii mahboubii left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gumuz shadowed should probably be discarded in this count too:
https://github.com/GetStream/stream-chat-js/blob/master/src/channel.ts#L1551

src/channel.ts Show resolved Hide resolved
@gumuz gumuz requested a review from mahboubii October 23, 2020 15:07
@gumuz gumuz requested review from mahboubii and removed request for mahboubii October 23, 2020 15:36
@mahboubii mahboubii merged commit 0223c80 into master Oct 26, 2020
@delete-merged-branch delete-merged-branch bot deleted the shadow-ban-fixes branch October 26, 2020 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahboubii mahboubii mahboubii approved these changes

@vishalnarkhede vishalnarkhede Awaiting requested review from vishalnarkhede vishalnarkhede is a code owner

@jaapbakker88 jaapbakker88 Awaiting requested review from jaapbakker88

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gumuz @mahboubii