Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CHAT-1851] Add assignRoles method to Channel #692

Merged
merged 9 commits into from
Jun 17, 2021
Merged

[CHAT-1851] Add assignRoles method to Channel #692

merged 9 commits into from
Jun 17, 2021

Conversation

AnatolyRugalev
Copy link
Contributor

@AnatolyRugalev AnatolyRugalev commented May 31, 2021 •
edited
Loading

This PR adds support for new setRoles operation in UpdateChannel API.

Also, did some refactoring around repetitive UpdateChannel SDK calls

UPDATE: renamed setRoles to assignRoles after discussion with the Product Team
UPDATE 2: switched format of assignRoles to object-based

@github-actions
Copy link
Contributor

github-actions bot commented May 31, 2021 •
edited
Loading

Size Change: +1.28 kB (0%)

Total Size: 229 kB

Filename Size Change
dist/browser.es.js 49.9 kB +310 B (0%)
dist/browser.full-bundle.min.js 28.5 kB +22 B (0%)
dist/browser.js 50.5 kB +320 B (0%)
dist/index.es.js 49.9 kB +310 B (0%)
dist/index.js 50.6 kB +318 B (0%)

compressed-size-action

@AnatolyRugalev AnatolyRugalev marked this pull request as ready for review May 31, 2021 14:13
AnatolyRugalev
AnatolyRugalev commented May 31, 2021
View reviewed changes
src/channel.ts Outdated Show resolved Hide resolved
ferhatelmas
ferhatelmas previously approved these changes Jun 1, 2021
View reviewed changes
Copy link
Contributor

@ferhatelmas ferhatelmas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Nice refactor. New addition is good, and types should be fine but I delegate types to type experts for final check 🙂

mahboubii
mahboubii reviewed Jun 1, 2021
View reviewed changes
src/types.ts Outdated Show resolved Hide resolved
src/channel.ts Show resolved Hide resolved
mahboubii
mahboubii previously approved these changes Jun 2, 2021
View reviewed changes
@AnatolyRugalev AnatolyRugalev changed the title [CHAT-1851] Add setRoles method to Channel [CHAT-1851] Add assignRoles method to Channel Jun 3, 2021
ferhatelmas
ferhatelmas previously approved these changes Jun 3, 2021
View reviewed changes
Copy link
Contributor

@ferhatelmas ferhatelmas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mahboubii
mahboubii previously approved these changes Jun 3, 2021
View reviewed changes
@AnatolyRugalev AnatolyRugalev dismissed stale reviews from mahboubii and ferhatelmas via 6677339 June 4, 2021 14:18
ferhatelmas
ferhatelmas approved these changes Jun 16, 2021
View reviewed changes
Copy link
Contributor

@ferhatelmas ferhatelmas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AnatolyRugalev AnatolyRugalev merged commit b65c42a into master Jun 17, 2021
@AnatolyRugalev AnatolyRugalev deleted the 1851-channel-member-role branch June 17, 2021 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferhatelmas ferhatelmas ferhatelmas approved these changes

@mahboubii mahboubii mahboubii left review comments

@vishalnarkhede vishalnarkhede Awaiting requested review from vishalnarkhede vishalnarkhede is a code owner

@nhannah nhannah Awaiting requested review from nhannah

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AnatolyRugalev @ferhatelmas @mahboubii