Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRNS-311: Handling channel.deleted event #728

Merged
merged 3 commits into from
Jul 28, 2021

Conversation

vishalnarkhede
Copy link
Contributor

CLA

  • I have signed the Stream CLA (required).
  • Code changes are tested

Description of the changes, What, Why and How?

Delete event for channel is not currently handled by our js client. So adding the event handler for it.

Changelog

  • Remove the channel from activeChannels list, once the channel is deleted.

@vishalnarkhede vishalnarkhede changed the title Handling channel.deleted event CRNS-311: Handling channel.deleted event Jul 28, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jul 28, 2021

Size Change: +300 B (0%)

Total Size: 241 kB

Filename Size Change
dist/browser.es.js 52.7 kB +70 B (0%)
dist/browser.full-bundle.min.js 29.4 kB +40 B (0%)
dist/browser.js 53.2 kB +60 B (0%)
dist/index.es.js 52.7 kB +70 B (0%)
dist/index.js 53.3 kB +60 B (0%)

compressed-size-action

src/client.ts Outdated Show resolved Hide resolved
@vishalnarkhede vishalnarkhede merged commit aef8a61 into master Jul 28, 2021
@vishalnarkhede vishalnarkhede deleted the vishal/channel-deleted-event branch July 28, 2021 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants