Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHAT-2260] Change Permission.Condition type #775

Merged
merged 9 commits into from
Sep 28, 2021

Conversation

AnatolyRugalev
Copy link
Contributor

@AnatolyRugalev AnatolyRugalev commented Sep 21, 2021

On the backend we are implementing proper support for condition field for custom permissions. This PR aims to synchronize API with the new version.

This is a breaking change, but since permissions v2 is yet to be released and condition feature for custom permissions is undocumented, I suggest we only bump minor version with appropriate release note

@github-actions
Copy link
Contributor

github-actions bot commented Sep 21, 2021

Size Change: 0 B

Total Size: 250 kB

ℹ️ View Unchanged
Filename Size Change
dist/browser.es.js 54.6 kB 0 B
dist/browser.full-bundle.min.js 30.1 kB 0 B
dist/browser.js 55.2 kB 0 B
dist/index.es.js 54.6 kB 0 B
dist/index.js 55.3 kB 0 B

compressed-size-action

@AnatolyRugalev AnatolyRugalev marked this pull request as ready for review September 23, 2021 08:38
@AnatolyRugalev AnatolyRugalev merged commit 2d9e86a into master Sep 28, 2021
@AnatolyRugalev AnatolyRugalev deleted the 2260-custom-permissions branch September 28, 2021 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants