feat: add full feature parity #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
peterdeme
commented
Jan 19, 2022
•
peterdeme
commented
- Add full feature parity
- Add super strict linter rules (including mandatory documentation and type hint ❗)
- added documentation where it was missing
- Fix linting issues
- removed ramsey/uuid package
- bumped packages
- small refactors
- ability to code in VS Code via Docker, plus added a small documentation for it in CONTRIBUTING.md
peterdeme
requested review from
AnatolyRugalev and
ferhatelmas
as code owners
peterdeme
force-pushed
the
feature-parity
branch
28 times, most recently
from
707ce22
to
0f615da
Compare
peterdeme
commented
Jan 19, 2022
| @@ -23,22 +27,23 @@ jobs: | |||
| uses: shivammathur/setup-php@v2 | |||
| with: | |||
| php-version: ${{ matrix.php-versions }} | |||
| extensions: mbstring, intl | |||
| extensions: ast, mbstring, intl | |||
There was a problem hiding this comment.
ast gives a performance boost to phan
peterdeme
commented
Jan 19, 2022
|
|
||
| - name: Quality | ||
| if: matrix.php-versions == '7.4' | ||
| run: vendor/bin/phan --force-polyfill-parser || true |
There was a problem hiding this comment.
force-polyfill-parser isn't needed anymore because of ast is added above
peterdeme
commented
Jan 19, 2022
| 'AvoidableGetterPlugin', | ||
| 'RemoveDebugStatementPlugin', | ||
| 'HasPHPDocPlugin', | ||
| ], |
There was a problem hiding this comment.
these plugins are amazing. i was able to catch and fix a few issues with it.
peterdeme
force-pushed
the
feature-parity
branch
from
0f615da
to
1d5c0b8
Compare
peterdeme
force-pushed
the
feature-parity
branch
from
1d5c0b8
to
444ffd7
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.