Skip to content

Commit

Permalink
[PBE-1321] rename targets to target_ids
Browse files Browse the repository at this point in the history
  • Loading branch information
kanat committed Feb 15, 2024
1 parent cb44fd7 commit 79218e1
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 16 deletions.
4 changes: 2 additions & 2 deletions stream_chat/async_chat/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -576,12 +576,12 @@ async def segment_target_exists(
async def add_segment_targets(
self, segment_id: str, target_ids: List[str]
) -> StreamResponse:
return await self.post(f"segments/{segment_id}/addtargets", data={"targets": target_ids})
return await self.post(f"segments/{segment_id}/addtargets", data={"target_ids": target_ids})

async def delete_segment_targets(
self, segment_id: str, target_ids: List[str]
) -> StreamResponse:
return await self.post(f"segments/{segment_id}/deletetargets", data={"targets": target_ids})
return await self.post(f"segments/{segment_id}/deletetargets", data={"target_ids": target_ids})

def campaign(self, campaign_id: Optional[str] = None, data: CampaignData = None) -> Campaign:
return Campaign(client=self, campaign_id=campaign_id, data=data)
Expand Down
9 changes: 0 additions & 9 deletions stream_chat/base/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -1089,15 +1089,6 @@ def test_campaign(
"""
pass

@abc.abstractmethod
def query_recipients(
self, **params: Any
) -> Union[StreamResponse, Awaitable[StreamResponse]]:
"""
Query recipients
"""
pass

@abc.abstractmethod
def revoke_tokens(
self, since: Union[str, datetime.datetime]
Expand Down
7 changes: 2 additions & 5 deletions stream_chat/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -554,12 +554,12 @@ def segment_target_exists(
def add_segment_targets(
self, segment_id: str, target_ids: List[str]
) -> StreamResponse:
return self.post(f"segments/{segment_id}/addtargets", data={"targets": target_ids})
return self.post(f"segments/{segment_id}/addtargets", data={"target_ids": target_ids})

def delete_segment_targets(
self, segment_id: str, target_ids: List[str]
) -> StreamResponse:
return self.post(f"segments/{segment_id}/deletetargets", data={"targets": target_ids})
return self.post(f"segments/{segment_id}/deletetargets", data={"target_ids": target_ids})

def campaign(self, campaign_id: Optional[str] = None, data: CampaignData = None) -> Campaign:
return Campaign(client=self, campaign_id=campaign_id, data=data)
Expand Down Expand Up @@ -602,9 +602,6 @@ def stop_campaign(self, campaign_id: str) -> StreamResponse:
def test_campaign(self, campaign_id: str, users: Iterable[str]) -> StreamResponse:
return self.post(f"campaigns/{campaign_id}/test", data={"users": users})

def query_recipients(self, **params: Any) -> StreamResponse:
return self.get("recipients", params={"payload": json.dumps(params)})

def revoke_tokens(self, since: Union[str, datetime.datetime]) -> StreamResponse:
if isinstance(since, datetime.datetime):
since = since.isoformat()
Expand Down

0 comments on commit 79218e1

Please sign in to comment.