Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: removing a reaction outside of the latest reactions causes to add it #2028

Merged
merged 2 commits into from
Mar 29, 2023
Merged

fix: removing a reaction outside of the latest reactions causes to add it #2028

merged 2 commits into from
Mar 29, 2023

Conversation

santhoshvai
Copy link
Member

@santhoshvai santhoshvai commented Mar 29, 2023 •
edited
Loading

🎯 Goal

Fixing the following bug reported by teamworks

when toggling a reaction off, we get breaking behavior if there are more than 10 messages AND my reaction wasn't in the last 10 reactions

so if my reaction isn't in the last 10 reactions, it should remove, but instead it adds, which causes silly behavior

☑️ Checklist

  • I have signed the Stream CLA (required)
  • PR targets the develop branch
  • Documentation is updated
  • New code is tested in main example apps, including all possible scenarios
    • SampleApp iOS and Android
    • Expo iOS and Android

@santhoshvai
Copy link
Member Author

quickly merging without review to release a beta for teamworks

@sonarcloud
Copy link

sonarcloud bot commented Mar 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@santhoshvai santhoshvai merged commit 87cf045 into develop Mar 29, 2023
@santhoshvai santhoshvai deleted the message-reactions-bug-fix branch March 29, 2023 14:14
@github-actions github-actions bot mentioned this pull request Mar 31, 2023
Merged
@stream-ci-bot
Copy link
Contributor

🎉 This PR is included in version 5.12.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@santhoshvai @stream-ci-bot