New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add optional logging for sqlite methods #2453
Conversation
🎉 This PR is included in version 5.26.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Hey @santhoshvai , just letting you know: with the upgrade from stream-chat-expo@5.24.0 to stream-chat-expo@5.26.0, I receive the following warning when I try to send a message:
Not quite sure if this PR is the root cause but there were some |
@RRaideRR thank you for letting me know.. JSON.stringify is not compliant with cyclical structure so this must be fixed |
@RRaideRR it seems like the PR is not the root cause here since the strigify was already present. I tried to send multiple messages and reactions and couldnt reproduce it. Do you have any reproduction paths of sending a message for me if any please? |
hey... it took me quite some time to create a minimal reproducible example here. The key is the CustomSendButton here. It seems like this is the root cause of all evil - if I strip it out, its working.
|
oh wow thanks, that should be it |
as per the typescript signature we provide.. your typing check should have broken this and changing that should have fixed it I am creating a fix for this, many thanks for pointing this out with reproducible example, that helped to find the cause of this issue 💯 👍 🎉 |
You're right. In my minimal reproducible example, TypeScript notified me about this. However, in my real-world scenario, I have something like this which runs fine:
Glad, that it's fixed now :=) |
Thank you @RRaideRR ! |
The goal is to provide a way to enable sqlite logging so that customers can easily report to us sqlite errors with trace of the reproduction steps.
in entry point of the app (index.js or App.tsx), integrators can add a custom logger.
For example, in TS example app the following logger is added:
Which results in rich logging in the chrome console:
Similarly, loggers can be added to crashlytics or bugsnag etc to trace this and report to us.