fix: offline support saving cyclic structure#2469
Merged
santhoshvai merged 2 commits intodevelopfrom Apr 1, 2024
Merged
Conversation
santhoshvai
commented
Apr 1, 2024
Member
Author
There was a problem hiding this comment.
removing all the ignored logs..
had it not been there we can catch these kind of bugs
khushal87
approved these changes
Apr 1, 2024
Merged
Contributor
|
🎉 This PR is included in version 5.27.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
due to #2422 we supported adding any custom fields to the message
but if an integrator adds
<TouchableOpacity onPress={sendMessage}>it will unintentionally add any touchable event params to the signature. And this creates a bug with offline support as it has cyclic structure.This was pointed out here
In this PR we change the signature of the method so that this cannot happen anymore