fix: scroll to bottom issue when the message list is empty #2471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santhoshvai
reviewed
Apr 2, 2024
Comment on lines
527
to
529
| } else { | ||
| setScrollToBottomButtonVisible(true); | ||
| setScrollToBottomButtonVisible(false); | ||
| } |
There was a problem hiding this comment.
this seems like a big change...
have you also tested with jump to message? its in sample-app mention screen
santhoshvai
reviewed
Apr 2, 2024
| @@ -805,13 +805,15 @@ const MessageListWithContext = < | |||
|
|
|||
| const handleScroll: ScrollViewProps['onScroll'] = (event) => { | |||
| const offset = event.nativeEvent.contentOffset.y; | |||
| const messageListHasMessages = channel.state.messages.length > 0; | |||
There was a problem hiding this comment.
how about thread list here? a thread list can also be empty right ?
you have to check this via the thread screen.. when navigating to a thread screen directly channel.state.messages.length has no relation..
so then we have to check the length of the message list that is used to render I believe
There was a problem hiding this comment.
it should be processedMessageList.length here in my view
santhoshvai
approved these changes
Apr 2, 2024
Merged
|
馃帀 This PR is included in version 5.27.0 馃帀 The release is available on: Your semantic-release bot 馃摝馃殌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃幆 Goal
The goal of the PR is to solve the scroll-to-bottom visible issue when the message list is empty and also not to show the scroll-to-bottom button after the offset is reached.
PFA the video attached that shows the previous and new behaviour(as per the PR):
Previous:
IMG_6093.MOV
New:
IMG_6092.MOV
馃洜 Implementation details
馃帹 UI Changes
iOS
Android
馃И Testing
鈽戯笍 Checklist
developbranch