Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: scroll to bottom issue when the message list is empty #2471

Merged
merged 3 commits into from
Apr 2, 2024
Merged

fix: scroll to bottom issue when the message list is empty #2471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c7e2047
fix: scroll to bottom issue when the message list is empty
khushal87 Apr 2, 2024
f779cf3
fix: sample app mentions screen bug
khushal87 Apr 2, 2024
9fa93d6
fix: sample app mentions screen bug
khushal87 Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions examples/SampleApp/src/hooks/usePaginatedSearchedMessages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ export const usePaginatedSearchedMessages = (
{
limit: DEFAULT_PAGINATION_LIMIT,
offset: offset.current,
sort: { updated_at: -1 },
},
);

Expand Down
6 changes: 4 additions & 2 deletions package/src/components/MessageList/MessageList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,7 +525,7 @@ const MessageListWithContext = <
if (threadList || hasNoMoreRecentMessagesToLoad) {
scrollToBottomIfNeeded();
} else {
setScrollToBottomButtonVisible(true);
setScrollToBottomButtonVisible(false);
}
Comment on lines 527 to 529
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems like a big change...

have you also tested with jump to message? its in sample-app mention screen

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works fine.


if (
Expand Down Expand Up @@ -805,13 +805,15 @@ const MessageListWithContext = <

const handleScroll: ScrollViewProps['onScroll'] = (event) => {
const offset = event.nativeEvent.contentOffset.y;
const messageListHasMessages = processedMessageList.length > 0;
// Show scrollToBottom button once scroll position goes beyond 150.
const isScrollAtBottom = offset <= 150;

const notLatestSet = channel.state.messages !== channel.state.latestMessages;

const showScrollToBottomButton =
(!threadList && notLatestSet) || !isScrollAtBottom || !hasNoMoreRecentMessagesToLoad;
messageListHasMessages &&
((!threadList && notLatestSet) || !isScrollAtBottom || !hasNoMoreRecentMessagesToLoad);

/**
* 1. If I scroll up -> show scrollToBottom button.
Expand Down
Loading