Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import React Dependency into Video / Sound files #1828

Conversation

AWildmanPerchPeek
Copy link
Contributor

@AWildmanPerchPeek AWildmanPerchPeek commented Nov 21, 2022

馃幆 Goal

Currently, if you try to play a video from chat or upload a mp3 file the sdk errors up saying React is not present inside the relevant files.

馃洜 Implementation details

Adding React import to Sound.tsx and Video.tsx

馃帹 UI Changes

None

iOS
Before After
Android
Before After

馃И Testing

Upload a Sound file to GetStream chat or a video file

鈽戯笍 Checklist

  • I have signed the Stream CLA (required)
  • PR targets the develop branch
  • [] Documentation is updated
  • [] New code is tested in main example apps, including all possible scenarios
    • [] SampleApp iOS and Android
    • [] Expo iOS and Android

@AWildmanPerchPeek AWildmanPerchPeek changed the title Import React Dependency into Video / Sound files bug: Import React Dependency into Video / Sound files Nov 21, 2022
@AWildmanPerchPeek AWildmanPerchPeek changed the title bug: Import React Dependency into Video / Sound files fix: Import React Dependency into Video / Sound files Nov 21, 2022
Copy link
Member

@khushal87 khushal87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks @AWildmanPerchPeek 馃殌

@khushal87 khushal87 changed the title fix: Import React Dependency into Video / Sound files fix: import React Dependency into Video / Sound files Nov 24, 2022
@khushal87 khushal87 merged commit 47f2e60 into GetStream:develop Nov 24, 2022
@github-actions github-actions bot mentioned this pull request Nov 24, 2022
6 tasks
@github-actions github-actions bot mentioned this pull request Dec 1, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants