Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typing issues in sample app #1942

Merged
merged 1 commit into from
Jan 31, 2023
Merged

Conversation

santhoshvai
Copy link
Member

@santhoshvai santhoshvai commented Jan 31, 2023

馃幆 Goal

Fixed some minor typing issues on the sample app

鈽戯笍 Checklist

  • I have signed the Stream CLA (required)
  • PR targets the develop branch
  • Documentation is updated
  • New code is tested in main example apps, including all possible scenarios
    • SampleApp iOS and Android
    • Expo iOS and Android

@sonarcloud
Copy link

sonarcloud bot commented Jan 31, 2023

Kudos, SonarCloud Quality Gate passed!聽 聽 Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@@ -185,6 +185,7 @@ const DrawerNavigatorWrapper: React.FC<{
<Chat<StreamChatGenerics>
client={chatClient}
enableOfflineSupport
// @ts-expect-error
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A thing to fix in the future so it will satisfy

@vanGalilea vanGalilea merged commit e2d34be into develop Jan 31, 2023
@vanGalilea vanGalilea deleted the fix-sample-app-typing-issue branch January 31, 2023 11:23
@github-actions github-actions bot mentioned this pull request Jan 31, 2023
@vishalnarkhede
Copy link
Contributor

馃帀 This PR is included in version 5.9.1 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants