Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: getPhotos doesn't work if you use android targetSdkVersion 33 #2036

Merged
merged 12 commits into from
Apr 5, 2023

Conversation

santhoshvai
Copy link
Member

@santhoshvai santhoshvai commented Apr 1, 2023

🎯 Goal

fixes #2022

🛠 Implementation details

Ask for new android media permissions if on rn 0.71 and Android 33

🧪 Testing

Change the RN version to 0.71 in sample app based on template and test

☑️ Checklist

  • I have signed the Stream CLA (required)
  • PR targets the develop branch
  • Documentation is updated
  • New code is tested in main example apps, including all possible scenarios
    • SampleApp iOS and Android
    • Expo iOS and Android

@santhoshvai santhoshvai marked this pull request as ready for review April 1, 2023 06:15
@santhoshvai santhoshvai self-assigned this Apr 3, 2023
@vanGalilea
Copy link
Contributor

All is well, after upgrading our TSM app to RN >0.71 yet know images are rendered to pick

Screenshot_1680623843

# Conflicts:
#	examples/SampleApp/ios/Podfile.lock
@vanGalilea vanGalilea merged commit a17957d into develop Apr 5, 2023
@vanGalilea vanGalilea deleted the feat/android-33-support branch April 5, 2023 14:00
@sonarcloud
Copy link

sonarcloud bot commented Apr 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@stream-ci-bot
Copy link
Contributor

🎉 This PR is included in version 5.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getPhotos doesn't work if you use compileSdkVersion 33
3 participants