Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enabling offline support with RNQS v8 and removing support for v4 #2067

Merged
merged 7 commits into from
Apr 21, 2023
Merged

feat: enabling offline support with RNQS v8 and removing support for v4 #2067

merged 7 commits into from
Apr 21, 2023

Conversation

vanGalilea
Copy link
Contributor

@vanGalilea vanGalilea commented Apr 20, 2023 •
edited
Loading

🎯 Goal

Check, test, and prevent future confusion around RN 0.71 < in combination with react-native-quick-sqlite 8.0.0 <

fixes #1952 (and tests) also fixes #1993

🛠 Implementation details

  • Using react-native-quick-sqlite v8 in our TSM app icw RN 0.71.6
  • Removing support for react-native-quick-sqlite v4
    -react-native-quick-sqlite addition to versions compatibilities table

🎨 UI Changes

N/A

🧪 Testing

Run TSM app, go offline, read messages, send messages etc.

☑️ Checklist

  • I have signed the Stream CLA (required)
  • PR targets the develop branch
  • Documentation is updated
  • New code is tested in main example apps, including all possible scenarios
    • SampleApp iOS and Android
    • Expo iOS and Android

@vanGalilea vanGalilea mentioned this pull request Apr 20, 2023
Closed
@vanGalilea vanGalilea mentioned this pull request Apr 20, 2023
Closed
@vanGalilea vanGalilea changed the title feat: enabling offline support with RNQS v8 feat: enabling offline support with RNQS v8 and removing support for v4 Apr 20, 2023
@vanGalilea vanGalilea marked this pull request as ready for review April 20, 2023 14:32
@santhoshvai
Copy link
Member

santhoshvai commented Apr 20, 2023 •
edited
Loading

Can we add the offline support to expo example app as well and update the docs please.

Or do we plan to do this in a separate PR.

@sonarcloud
Copy link

sonarcloud bot commented Apr 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

63.9% 63.9% Coverage
0.0% 0.0% Duplication

@vanGalilea
Copy link
Contributor Author

Can we add the offline support to expo example app as well and update the docs please.

Or do we plan to do this in a separate PR.

Working on it now in separate pr ;)

@vanGalilea vanGalilea merged commit 22a541c into develop Apr 21, 2023
6 checks passed
@vanGalilea vanGalilea deleted the feat/sqllite-v8 branch April 21, 2023 15:33
@github-actions github-actions bot mentioned this pull request Apr 28, 2023
Merged
6 tasks
@stream-ci-bot
Copy link
Contributor

🎉 This PR is included in version 5.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khushal87 khushal87 Awaiting requested review from khushal87

@santhoshvai santhoshvai Awaiting requested review from santhoshvai

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Offline support breaks when using React Native Debugger Support for react-native-quick-sqlite v8
3 participants
@vanGalilea @santhoshvai @stream-ci-bot