fix: android picker loop on refuse permission #2130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also would happen when dismissing modal
santhoshvai
approved these changes
Aug 3, 2023
|
馃帀 This PR is included in version 5.16.0 馃帀 The release is available on: Your semantic-release bot 馃摝馃殌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2129
馃幆 Goal
馃洜 Implementation details
onEndReachedon error states, since that would either show the prompt again or enter a loop until the user gives permission.馃帹 UI Changes
N/A
馃И Testing
Call
toggleAttachmentPickerfromuseMessageInputContexton an Android and either deny permission or click outside the Modal.鈽戯笍 Checklist
developbranch