Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue with picking files through filePicker with recent version of expo-document-picker #2203

Merged
merged 5 commits into from
Aug 2, 2023

Conversation

khushal87
Copy link
Member

🎯 Goal

This PR fixes the issue with the attachments name with the new version of the document picker. This is also backward compatible.

🛠 Implementation details

The code is made backward compatible to handle both old and new versions.

🎨 UI Changes

None

iOS
Before After
Android
Before After

🧪 Testing

☑️ Checklist

  • I have signed the Stream CLA (required)
  • PR targets the develop branch
  • Documentation is updated
  • New code is tested in main example apps, including all possible scenarios
    • SampleApp iOS and Android
    • Expo iOS and Android

@khushal87 khushal87 marked this pull request as draft August 2, 2023 10:49
@khushal87 khushal87 marked this pull request as ready for review August 2, 2023 10:50
@sonarcloud
Copy link

sonarcloud bot commented Aug 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

62.5% 62.5% Coverage
0.0% 0.0% Duplication

@santhoshvai santhoshvai merged commit b7d1fa6 into develop Aug 2, 2023
8 checks passed
@santhoshvai santhoshvai deleted the khushal87/expo-document-picker-fix branch August 2, 2023 13:53
@github-actions github-actions bot mentioned this pull request Aug 4, 2023
6 tasks
@stream-ci-bot
Copy link
Contributor

🎉 This PR is included in version 5.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants