fix: video upload issue through image picker #2204
Conversation
| // Since Expo MediaLibrary doesn't return the mimetype of the image/video, we have to derive the mimeType. | ||
| const mimeType = lookup(asset.filename) || 'multipart/form-data'; |
There was a problem hiding this comment.
if expo is the only that doesnt return mime type why is it being done for both here ?
There was a problem hiding this comment.
as per expo docs, mimetype is optionally present in the asset type
https://docs.expo.dev/versions/latest/sdk/document-picker/#documentpickerasset
There was a problem hiding this comment.
also present in older versions
https://docs.expo.dev/versions/v47.0.0/sdk/document-picker/#documentresult
There was a problem hiding this comment.
If you read the comment above, I am not saying expo doesn't do that(send mimeType in response). Expo MediaLibrary doesn't do that, Expo DocumentPicker does. In our SDK we don't do a lookup for the code for the document picker or file picker, we do it for the image picker/media library @santhoshvai
There was a problem hiding this comment.
I thought its related to document picker, because you said that this was broken by the docu,ent picker version update
There was a problem hiding this comment.
No, what I meant was the previous PR of the document picker that was merged yesterday caused this issue of video upload because mime-type was compulsory.
There was a problem hiding this comment.
There's a better way to fix this and that we discussed yesterday, handling lookup in the expo-package and native-package and sending mimetype through the package itself
|
Kudos, SonarCloud Quality Gate passed!聽 聽
|
|
馃帀 This PR is included in version 5.16.0 馃帀 The release is available on: Your semantic-release bot 馃摝馃殌 |
馃幆 Goal
馃洜 Implementation details
馃帹 UI Changes
iOS
Android
馃И Testing
鈽戯笍 Checklist
developbranch