Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sample-app crash because of viewport changes #2313

Merged
merged 1 commit into from
Nov 15, 2023
Merged

fix: sample-app crash because of viewport changes #2313

merged 1 commit into from
Nov 15, 2023

Conversation

khushal87
Copy link
Member

馃幆 Goal

Fixes sample app crash due to #2310

馃洜 Implementation details

馃帹 UI Changes

iOS
Before After
Android
Before After

馃И Testing

鈽戯笍 Checklist

  • I have signed the Stream CLA (required)
  • PR targets the develop branch
  • Documentation is updated
  • New code is tested in main example apps, including all possible scenarios
    • SampleApp iOS and Android
    • Expo iOS and Android

@vishalnarkhede vishalnarkhede merged commit be241e1 into develop Nov 15, 2023
6 checks passed
@vishalnarkhede vishalnarkhede deleted the fix-sample-app-crash branch November 15, 2023 15:19
@github-actions github-actions bot mentioned this pull request Nov 15, 2023
Merged
6 tasks
@stream-ci-bot
Copy link
Contributor

馃帀 This PR is included in version 5.22.0 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@santhoshvai santhoshvai santhoshvai approved these changes

@vishalnarkhede vishalnarkhede vishalnarkhede approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@khushal87 @stream-ci-bot @santhoshvai @vishalnarkhede