Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: outdated unread count on offline support #2412

Merged
merged 3 commits into from Feb 5, 2024

Conversation

santhoshvai
Copy link
Member

@santhoshvai santhoshvai commented Feb 2, 2024

馃幆 Goal

fixes #2377 #1996

Fixes a race condition between unread count update and channel query update while being on offline support

the issue is that channel preview does not update after query channels on offline support.. and this force update causes it to

馃洜 Implementation details

馃帹 UI Changes

iOS
Before After
Android
Before After

馃И Testing

鈽戯笍 Checklist

  • I have signed the Stream CLA (required)
  • PR targets the develop branch
  • Documentation is updated
  • New code is tested in main example apps, including all possible scenarios
    • SampleApp iOS and Android
    • Expo iOS and Android

@santhoshvai santhoshvai changed the title fix: unread count on offline support fix: outdated unread count on offline support Feb 2, 2024
@santhoshvai santhoshvai marked this pull request as ready for review February 2, 2024 15:49
@santhoshvai santhoshvai linked an issue Feb 2, 2024 that may be closed by this pull request
8 tasks
@santhoshvai santhoshvai merged commit 4d1bf2d into develop Feb 5, 2024
11 checks passed
@santhoshvai santhoshvai deleted the santhoshvai-patch-1 branch February 5, 2024 12:21
@github-actions github-actions bot mentioned this pull request Feb 5, 2024
6 tasks
@stream-ci-bot
Copy link
Contributor

馃帀 This PR is included in version 5.24.0 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[馃悰] Offline Mode Unread Count Out of Sync
2 participants