chore: upgrade react native SDK version to 0.73.6 and fix incompatibilies #2475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santhoshvai
reviewed
Apr 8, 2024
There was a problem hiding this comment.
please dont change to pressable as the previous opacity animation is now lost
santhoshvai
reviewed
Apr 9, 2024
| /** | ||
| * Typescript currently does not support partial inference so if ThreadContext | ||
| * typing is desired while using the HOC withThreadContextContext the Props for the | ||
| * @deprecated because of no usage |
There was a problem hiding this comment.
can we remove because of no usage in all equivalent comments please..
the reason below is acceptable enough in my view
santhoshvai
reviewed
Apr 9, 2024
| @@ -87,7 +87,7 @@ export const MessageSystem = < | |||
| <Text style={[styles.text, { color: grey }, text]}> | |||
| {message.text?.toUpperCase() || ''} | |||
| </Text> | |||
| <Text style={[styles.text, { color: grey }, dateText]}>{date}</Text> | |||
| <Text style={[styles.text, { color: grey }, dateText]}>{date.toString()}</Text> | |||
There was a problem hiding this comment.
wow this is actually a bug fix 👏
santhoshvai
approved these changes
Apr 9, 2024
|
🎉 This PR is included in version 5.27.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
🛠 Implementation details
🎨 UI Changes
iOS
Android
🧪 Testing
☑️ Checklist
developbranch