feat: move react-native-quick-sqlite to op-sqlite #2541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santhoshvai
reviewed
Jun 6, 2024
| @@ -26,12 +26,12 @@ The following features are currently **NOT** implemented. They will be impleme | |||
|
|
|||
| First and foremost, make sure to follow all steps from [Migrating to v5](../basics/migrating-from-4.x-to-5.x.mdx) guide. To enable offline support, please follow the given steps: | |||
There was a problem hiding this comment.
Suggested change
| First and foremost, make sure to follow all steps from [Migrating to v5](../basics/migrating-from-4.x-to-5.x.mdx) guide. To enable offline support, please follow the given steps: | |
| First and foremost, make sure to follow all steps from [Migrating to v5](../basics/migrating-from-4.x-to-5.x.mdx) guide. To enable offline support, please follow the given steps: |
this should be changed to v5 to v6. For later PR i think. But mentioning here to not forget.
santhoshvai
reviewed
Jun 6, 2024
examples/SampleApp/ios/Podfile
Outdated
There was a problem hiding this comment.
this seems like big change.. did you test push notifications after this?
There was a problem hiding this comment.
I have removed the changes and added the suggested way as per the official docs of op-sqlite. Updated the troubleshoot section as well in push notifications v2 docs.
santhoshvai
approved these changes
Jun 6, 2024
|
Can this be merged so we can move to Expo 51? |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
The goal of the PR is to move to
op-sqliterather thanreact-native-quick-sqlitefor our offline storage as it is much faster and also allows new architecture support.🛠 Implementation details
🎨 UI Changes
iOS
Android
🧪 Testing
☑️ Checklist
developbranch