bug: SuggestionList prop types are unused and outdated #1659
Labels
bug
Something isn't working
released
status:confirmed
Described issue has been reproduced by the repo maintainer
Comments
petyosi
added
status:confirmed
petyosi
added a commit
that referenced
this issue
Jul 28, 2022
|
Agreed, these are not perfect. The autocomplete textarea has not been migrated to typescript (it's, in fact, a fork of a semi-dormant project) - we've been looking into this for a while. In the meantime, I updated the types we export. |
github-actions bot
pushed a commit
that referenced
this issue
Jul 29, 2022
# [9.3.0](v9.2.0...v9.3.0) (2022-07-29) ### Bug Fixes * scroll to bottom on new message notification click after message list pagination ([#1689](#1689)) ([d8f4bc5](d8f4bc5)) * update types for suggestions ([#1691](#1691)) ([bb7442c](bb7442c)), closes [#1659](#1659) ### Features * **message-status:** extendable user information in read-by tooltip ([#1670](#1670)) ([902029a](902029a))
|
🎉 This issue has been resolved in version 9.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The SuggestionItemProps and SuggestionListProps are both outdated and unused in their components. This makes it difficult to extend the functionality with our own implementation and ensure they still align on future releases.
The
SuggestionList(defined here) does not use theSuggestionListProps. The props in this component also don't match that type completely. E.g. Several props likecurrentTriggerandselectionEndare used in the component, but not defined in the type.The
SuggestionItem(defined here) has the same problem.Expected behavior
The types should match their components and be used in those components to the ensure stability in future releases and allow users to safely extend this functionality.
Package version
The text was updated successfully, but these errors were encountered: