-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add AudioRecorder tests #2373
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2373 +/- ##
==========================================
+ Coverage 84.71% 84.83% +0.11%
==========================================
Files 386 386
Lines 8886 8890 +4
Branches 2268 2269 +1
==========================================
+ Hits 7528 7542 +14
+ Misses 1167 1160 -7
+ Partials 191 188 -3 ☔ View full report in Codecov by Sentry. |
Size Change: +478 B (0%) Total Size: 2.13 MB
ℹ️ View Unchanged
|
const state = useMemo( | ||
() => ({ | ||
paused: recordingState === MediaRecordingState.PAUSED, | ||
recording: recordingState === MediaRecordingState.RECORDING, | ||
stopped: recordingState === MediaRecordingState.STOPPED, | ||
}), | ||
[recordingState], | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is no need to memoize this. Inlining these values should be simpler:
const paused = recordingState === MediaRecordingState.PAUSED;
...
🎉 This PR is included in version 11.16.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎯 Goal
Add missing tests from #2339