feat: allow custom attachments #2383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +15.4 kB (+1%) Total Size: 2.14 MB
ℹ️ View Unchanged
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2383 +/- ##
==========================================
+ Coverage 84.87% 85.31% +0.43%
==========================================
Files 386 392 +6
Lines 8908 9021 +113
Branches 2274 2320 +46
==========================================
+ Hits 7561 7696 +135
+ Misses 1160 1118 -42
- Partials 187 207 +20 ☔ View full report in Codecov by Sentry. |
MartinCupela
commented
May 8, 2024
MartinCupela
commented
May 8, 2024
docusaurus/docs/React/guides/message-input/attachment-previews.mdx
Outdated
Show resolved
Hide resolved
Comment on lines
+143
to
+145
| upsertAttachments: ( | ||
| attachments: (Attachment<StreamChatGenerics> | LocalAttachment<StreamChatGenerics>)[], | ||
| ) => void; |
There was a problem hiding this comment.
Suggested change
| upsertAttachments: ( | |
| attachments: (Attachment<StreamChatGenerics> | LocalAttachment<StreamChatGenerics>)[], | |
| ) => void; | |
| upsertAttachments: ( | |
| attachments: (Attachment<StreamChatGenerics> | LocalAttachment<StreamChatGenerics>)[], | |
| ) => void; |
nit/feat: Could integrators benefit from patch function?
upsertAttachments((currentAttachments) => {
return currentAttachments.map((attachment) => {
if (attachment.id !== arbitraryId) return attachment;
return { ...attachment, localMetadata: { ...attachment.localMetadata, customThing: 123 } };
});
});
Co-authored-by: Anton Arnautov <43254280+arnautov-anton@users.noreply.github.com>
…nto feat/allow-custom-attachments
MartinCupela
commented
May 8, 2024
| if (attachmentIndex === -1) { | ||
| attachments.push(actionAttachment); | ||
| } else { | ||
| const upsertedAttachment = mergeDeep( |
There was a problem hiding this comment.
@arnautov-anton regarding your question about patching the attachments. It happens here.
|
🎉 This PR is included in version 11.18.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Allow integrators to add custom attachments to a composed message. This is possible via
upsertAttachmentandremoveAttachmentfunctions exposed viaMessageInputContextValue. Both functions expect arrays of values to perform batch updates.The integrators can customize the look of custom attachments by providing custom components:
UnsupportedAttachmenttoAttachmentcomponent wrapper.UnknownAttachmenttoAttachmentPreviewListcomponent wrapper.AttachmentandAttachmentPreviewListwrappers are then passed toChannelas props.🎨 UI Changes
Unknown attachments are by default rendered as follows: