feat: adopt new queryReactions endpoint #2388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +358 B (+0.02%) Total Size: 2.14 MB
ℹ️ View Unchanged
|
myandrienko
changed the title
myandrienko
requested review from
arnautov-anton,
oliverlaz,
szuperaz and
MartinCupela
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2388 +/- ##
==========================================
- Coverage 85.31% 85.28% -0.03%
==========================================
Files 392 392
Lines 9021 9025 +4
Branches 2320 2320
==========================================
+ Hits 7696 7697 +1
- Misses 1118 1120 +2
- Partials 207 208 +1 ☔ View full report in Codecov by Sentry. |
szuperaz
approved these changes
May 21, 2024
oliverlaz
approved these changes
May 22, 2024
github-actions bot
pushed a commit
that referenced
this pull request
May 23, 2024
## [11.19.0](v11.18.1...v11.19.0) (2024-05-23) ### Bug Fixes * fix aria label translations for Portuguese ([28b6dfd](28b6dfd)) * prevent loading more non-existent thread replies ([#2399](#2399)) ([f2ed479](f2ed479)) * prevent showing link previews in AttachmentPreviewList ([#2398](#2398)) ([cf24894](cf24894)) ### Features * adopt new queryReactions endpoint ([#2388](#2388)) ([d6ca4ef](d6ca4ef))
|
🎉 This PR is included in version 11.19.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚂 GetStream/stream-chat-js#1279
The new
queryReactionsendpoint supports backend filtering and sorting, so now we don't have to fetch all reactions and then process them on the client.sortReactionDetailsprop for client-side filtering is still supported, but deprecated. The new recommended way is to passreactionDetailsSortobject which will be passed in the reactions query.