feat: load lazily mp3 encoding library for audio recorder #2432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinCupela
force-pushed
the
feat/lazy-load-lame-js
branch
from
405beeb
to
0ba9483
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-v11 #2432 +/- ##
===============================================
- Coverage 85.45% 85.44% -0.02%
===============================================
Files 392 392
Lines 9078 9078
Branches 2346 2345 -1
===============================================
- Hits 7758 7757 -1
- Misses 1119 1120 +1
Partials 201 201 ☔ View full report in Codecov by Sentry. |
oliverlaz
reviewed
Jun 19, 2024
arnautov-anton
approved these changes
Jun 21, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jun 21, 2024
## [11.22.0](v11.21.0...v11.22.0) (2024-06-21) ### Bug Fixes * adjust ChannelActionContextValue type ([#2434](#2434)) ([977ec39](977ec39)) * avoid eager channel pagination on channel open ([#2425](#2425)) ([c1e8b93](c1e8b93)) * keep line breaks in message text that contains multiple markdown elements ([#2429](#2429)) ([11e606f](11e606f)) ### Features * load lazily mp3 encoding library for audio recorder ([#2432](#2432)) ([2ca3188](2ca3188))
|
🎉 This PR is included in version 11.22.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Bundle @breezystack/lamejs separately and thus load it only if audio recording is enabled.