Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to truncation #60

Merged
merged 3 commits into from
Nov 25, 2021
Merged

Add options to truncation #60

merged 3 commits into from
Nov 25, 2021

Conversation

driver-devel
Copy link
Contributor

Submit a pull request

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

Allow to pass options for truncate channel action

spec/channel_spec.rb Outdated Show resolved Hide resolved
spec/channel_spec.rb Outdated Show resolved Hide resolved
Copy link
Contributor

@ferhatelmas ferhatelmas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ferhatelmas ferhatelmas marked this pull request as ready for review November 25, 2021 12:43
@ferhatelmas ferhatelmas merged commit ed6ffa5 into master Nov 25, 2021
@ferhatelmas ferhatelmas deleted the truncate-options branch November 25, 2021 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants