Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expose rate limits #72

Merged
merged 1 commit into from
Jan 26, 2022
Merged

feat: expose rate limits #72

merged 1 commit into from
Jan 26, 2022

Conversation

peterdeme
Copy link
Contributor

  • Add rate limit to response object

@ffenix113
Copy link
Contributor

I just opened laptop to do just this! 😅

Let's also add headers. What do you think about having some class for rate limiter info, just like in Python SDK?

@peterdeme
Copy link
Contributor Author

@ffenix113 done

ferhatelmas
ferhatelmas reviewed Jan 26, 2022
View reviewed changes
stream-chat.gemspec Outdated Show resolved Hide resolved
ffenix113
ffenix113 approved these changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@ffenix113 ffenix113 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@peterdeme peterdeme merged commit 3f1ad5c into master Jan 26, 2022
@peterdeme peterdeme deleted the rate-limit branch January 26, 2022 11:43
@github-actions github-actions bot mentioned this pull request Jan 26, 2022
Merged
@ffenix113 ffenix113 mentioned this pull request Feb 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferhatelmas ferhatelmas ferhatelmas approved these changes

@ffenix113 ffenix113 ffenix113 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@peterdeme @ffenix113 @ferhatelmas