feat: ability to provide custom http client #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferhatelmas
reviewed
Feb 1, 2022
peterdeme
force-pushed
the
custom-client
branch
from
33bc8d3
to
e1c53fb
Compare
ffenix113
reviewed
Feb 1, 2022
ferhatelmas
approved these changes
Feb 1, 2022
peterdeme
force-pushed
the
custom-client
branch
from
e1c53fb
to
38cebb6
Compare
ffenix113
reviewed
Feb 1, 2022
| # initializes a Stream Chat API Client from STREAM_KEY and STREAM_SECRET | ||
| # environmental variables. | ||
| def self.from_env | ||
| Client.new(ENV['STREAM_KEY'], ENV['STREAM_SECRET']) |
There was a problem hiding this comment.
As we have @api_key = api_key || ENV['STREAM_KEY'] do you think we need to provide values here instead of just Client.new?
I also see that we need to change def initialize(api_key = '', api_secret = '', timeout = 6.0, **options) to def initialize(api_key = nil, api_secret = nil, timeout = 6.0, **options) so in function it will pick up environment variables. Seems like a bug.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ability to provide custom http client