feat: add sorbet type checker #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
peterdeme
commented
Feb 9, 2022
peterdeme
commented
- Add types. Runtime check is disabled, but static check is enabled.
- Add type checking to CI
peterdeme
force-pushed
the
sorbet-typing
branch
7 times, most recently
from
3cedae5
to
e0de8f8
Compare
ffenix113
reviewed
Feb 10, 2022
ffenix113
reviewed
Feb 10, 2022
| # We will enable it with a major bump in the future, | ||
| # but for now, let's just run a static type check. | ||
|
|
||
| StringKeyHash = T.type_alias { T::Hash[T.any(String, Symbol), T.untyped] } |
There was a problem hiding this comment.
We had issues with having strings/symbols in maps before, would you think we should allow only symbols here in next major version?
There was a problem hiding this comment.
Agreed. Want me to modify this to this?
SymbolKeyHash = T.type_alias { T::Hash[Symbol, T.untyped] }There was a problem hiding this comment.
Yes, I think it would be right move.
There was a problem hiding this comment.
@ffenix113 I looked into it. Unfortunately we rely on string in many places already so right now I wouldn't make that change. Right before bumping to the next major, sure.
peterdeme
force-pushed
the
sorbet-typing
branch
2 times, most recently
from
657e260
to
08ee246
Compare
peterdeme
force-pushed
the
sorbet-typing
branch
from
08ee246
to
98106c3
Compare
ffenix113
approved these changes
Feb 10, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.