Add unread message count in query channels response #247
Conversation
Generated by 🚫 Danger |
@buh That's not totally possible. MessageRead doesn't include mentioned messages, and it's not sent for new & deleted messages. I think we should keep the current solution for now. |
There was a problem hiding this comment.
It shouldn't be sent for new and delete messages.
I think you need to check the unread count flow.
So, we have a number from the request, if we will calculate by messages probably the number will be less because of messages limits. We should use the maximum otherwise it will be useless.
Unread count calculation required a request with state and watch. Now it looks like a mess with calculation and response value. Probably we need to request the mentioned unread count from the backend and omit it on our side.
messagesUnreadCount -> unreadMessagesCount channelsUnreadCount -> unreadChannelsCount These are internal so no API changes
| guard let eventCid = event.cid, let watchingChannels = watchingChannelsAtomic[eventCid] else { | ||
| return | ||
| } | ||
|
|
||
| // Update watching channels for unread count and watcher count. | ||
| watchingChannels.forEach { | ||
| if let channel = $0.value { | ||
| if let channel = $0.value, channel.cid == eventCid { |
There was a problem hiding this comment.
This is no needed because watchingChannels contains channels with the same cid:
guard let eventCid = event.cid, let watchingChannels = watchingChannelsAtomic[eventCid] else {There was a problem hiding this comment.
OK, I've added it since it was like that for notificationMessageNew part. Will remove it.
| if unreadMessageRead.unreadMessageCount > 0 { | ||
| // Calculate mentioned message unread count | ||
| // This is approximate since it'll be limited for the messages we've fetched | ||
| for message in messages.reversed() { | ||
| if message.user.isCurrent { | ||
| continue | ||
| } | ||
|
|
||
| if message.user != currentUser, message.mentionedUsers.contains(currentUser) { | ||
| unreadCount.mentionedMessages += 1 | ||
| if message.created > unreadMessageRead.lastReadDate { | ||
| if message.user != currentUser, message.mentionedUsers.contains(currentUser) { | ||
| unreadCount.mentionedMessages += 1 | ||
| } | ||
| } else { | ||
| break | ||
| } | ||
| } else { | ||
| break | ||
| } | ||
| } |
There was a problem hiding this comment.
suggestion:
// Calculate mentioned message unread count
// This is approximate since it'll be limited for the messages we've fetched
for message in messages.reversed() where !message.user.isCurrent {
if message.created > unreadMessageRead.lastReadDate {
if message.mentionedUsers.contains(currentUser) {
unreadCount.mentionedMessages += 1
}
} else {
break
}
}
No description provided.