Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIS-803] Change fetching devices to be called explicitly #1010

Merged
merged 3 commits into from Apr 22, 2021

Conversation

nuno-vieira
Copy link
Member

@nuno-vieira nuno-vieira commented Apr 22, 2021

In this PR

  • Removes CurrentUserUpdater.fetchDevices() call from CurrentUserController.synchronize()
  • Adds CurrentUserController.synchronizeDevices()

Copy link
Contributor

@VojtaStavik VojtaStavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. I have a nit comment about naming + CHANGELOG and we're good to merge 👍

@nuno-vieira nuno-vieira added the 🌐 SDK: StreamChat (LLC) Tasks related to the StreamChat LLC SDK label Apr 22, 2021
@nuno-vieira nuno-vieira force-pushed the CIS-803-call-fetch-devices-explicity branch 2 times, most recently from 8dac9b7 to f102030 Compare April 22, 2021 10:58
@codecov
Copy link

codecov bot commented Apr 22, 2021

Codecov Report

Merging #1010 (8b83d3c) into main (8bd1e46) will decrease coverage by 0.19%.
The diff coverage is 94.44%.

❗ Current head 8b83d3c differs from pull request most recent head e71d6a5. Consider uploading reports for the commit e71d6a5 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1010      +/-   ##
==========================================
- Coverage   89.73%   89.53%   -0.20%     
==========================================
  Files         210      210              
  Lines        8758     8774      +16     
==========================================
- Hits         7859     7856       -3     
- Misses        899      918      +19     
Flag Coverage Δ
llc-tests 89.53% <94.44%> (-0.03%) ⬇️
llc-tests-ios12 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Sources/StreamChat/Workers/ChatClientUpdater.swift 97.91% <50.00%> (ø)
Sources/StreamChat/ChatClient.swift 96.58% <100.00%> (ø)
.../CurrentUserController/CurrentUserController.swift 94.61% <100.00%> (+0.40%) ⬆️
...ocketClient/Engine/StarscreamWebSocketEngine.swift 0.00% <0.00%> (-30.96%) ⬇️
Sources/StreamChat/Database/DTOs/MessageDTO.swift 94.39% <0.00%> (-1.05%) ⬇️
.../Utils/InternetConnection/InternetConnection.swift 54.05% <0.00%> (-0.91%) ⬇️
...ources/StreamChat/Database/DatabaseContainer.swift 96.12% <0.00%> (-0.78%) ⬇️
Sources/StreamChat/Models/Message.swift 88.63% <0.00%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3963ea0...e71d6a5. Read the comment docs.

@nuno-vieira nuno-vieira force-pushed the CIS-803-call-fetch-devices-explicity branch from f102030 to c9b6ce2 Compare April 22, 2021 15:08
@nuno-vieira nuno-vieira force-pushed the CIS-803-call-fetch-devices-explicity branch from 8b83d3c to e71d6a5 Compare April 22, 2021 16:46
@nuno-vieira nuno-vieira merged commit bbcbb87 into main Apr 22, 2021
@nuno-vieira nuno-vieira deleted the CIS-803-call-fetch-devices-explicity branch April 22, 2021 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌐 SDK: StreamChat (LLC) Tasks related to the StreamChat LLC SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants