New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CIS-803] Change fetching devices to be called explicitly #1010
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. I have a nit comment about naming + CHANGELOG and we're good to merge 👍
Sources/StreamChat/Controllers/CurrentUserController/CurrentUserController.swift
Outdated
Show resolved
Hide resolved
8dac9b7
to
f102030
Compare
Codecov Report
@@ Coverage Diff @@
## main #1010 +/- ##
==========================================
- Coverage 89.73% 89.53% -0.20%
==========================================
Files 210 210
Lines 8758 8774 +16
==========================================
- Hits 7859 7856 -3
- Misses 899 918 +19
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
f102030
to
c9b6ce2
Compare
Now it waits for the web socket connection to be successful in order to change the state to `.remoteDataFetched`
8b83d3c
to
e71d6a5
Compare
In this PR
CurrentUserUpdater.fetchDevices()
call fromCurrentUserController.synchronize()
CurrentUserController.synchronizeDevices()