[CIS-805] Refresh channel list queries when current user membership changes #1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VojtaStavik
added
the
🌐 SDK: StreamChat (LLC)
DominikBucher12
approved these changes
Apr 23, 2021
| @@ -8,9 +8,8 @@ public protocol ConnectionEvent: Event { | |||
| var connectionId: String { get } | |||
| } | |||
|
|
|||
| public struct HealthCheckEvent: ConnectionEvent, EventWithPayload, EventWithCurrentUserPayload { | |||
| public struct HealthCheckEvent: ConnectionEvent, EventWithPayload { | |||
| updateChannelListQuery(for: channelDTO) | ||
| database.write { | ||
| let dto = $0.channel(cid: try! ChannelId(cid: channelDTO.cid)) | ||
| dto?.needsRefreshQueries = false |
There was a problem hiding this comment.
I don't understand what is gooing on here 😅 Maybe add little documentation? This makes me wonder why it doesn't need to refresh queries...
nuno-vieira
reviewed
Apr 23, 2021
| try session.saveMember(payload: memberPayload, channelId: memberEvent.cid) | ||
| case is MemberRemovedEvent: | ||
| guard let channel = session.channel(cid: memberEvent.cid) else { | ||
| try session.saveMember(payload: memberPayload, channelId: (event as! EventWithChannelId).cid) |
There was a problem hiding this comment.
event as! EventWithChannelId are we sure this is always true? Why the force unwrap? 🤔
There was a problem hiding this comment.
MemberRemovedEvent is always EventWithChannelId :) @nuno-vieira
nuno-vieira
reviewed
Apr 23, 2021
| @@ -72,7 +72,14 @@ final class NewChannelQueryUpdater<ExtraData: ExtraDataTypes>: Worker { | |||
| changes.forEach { change in | |||
| switch change { | |||
| case let .insert(channelDTO, _): | |||
| updateChannelListQuery(for: channelDTO) | |||
| database.write { | |||
| let dto = $0.channel(cid: try! ChannelId(cid: channelDTO.cid)) | |||
There was a problem hiding this comment.
Is this force unwrap safe as well?
Codecov Report
@@ Coverage Diff @@
## main #1016 +/- ##
==========================================
+ Coverage 89.78% 89.93% +0.14%
==========================================
Files 211 213 +2
Lines 8872 8943 +71
==========================================
+ Hits 7966 8043 +77
+ Misses 906 900 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
nuno-vieira
pushed a commit
that referenced
this pull request
Apr 23, 2021
…hanges (#1016) * Expose `queries` field on `ChannelDTO` * Add `needsRefreshQueries` field to `ChannelDTO` * Make `NewChannelQueryUpdater` respect `needsRefreshQueries` * Make it possible to create mock channels with query * Streamline events protocols * Invalidate `ChannelDTO` queries when current user changes membership * Update CHANGELOG * fixup! Streamline events protocols
nuno-vieira
pushed a commit
that referenced
this pull request
Apr 23, 2021
…hanges (#1016) * Expose `queries` field on `ChannelDTO` * Add `needsRefreshQueries` field to `ChannelDTO` * Make `NewChannelQueryUpdater` respect `needsRefreshQueries` * Make it possible to create mock channels with query * Streamline events protocols * Invalidate `ChannelDTO` queries when current user changes membership * Update CHANGELOG * fixup! Streamline events protocols
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the existing queries for a channel invalidated when the current user membership changes. In other words - when you stop being a member of a channel, you won't see it in the list :)