Fix newly joined members not having ChannelReads #1068
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cases:
messageRead
event-> We discard the event and
log.debug
itmessageRead
event-> We create a read event for User B, this is the fix introduced in this PR
messageRead
event-> Since User B is an old member, we received their read object when we queried the channel
-> User A doesn't have a read object until they re-query the channel (backend bug) or they join, we
log.info
the case->
MemberEventMiddleware
received thememberAdded
event and re-queries the channel, creating a read object-> This is the only edge-edge case, before
MemberEventMiddleware
finishes creating the read object, all new messages cause thelog.info
log-> Since User A is an old member, we received their read object when we queried the channel