Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIS-858] Always refetch queries when reconnected #1092

Merged
merged 3 commits into from May 21, 2021

Conversation

VojtaStavik
Copy link
Contributor

Turn our the /sync endpoint returns only the events for the channels specified in the request. This means if the current user is added to a new channel while offline, the new channel won't appear in the channel list.

  • the first commit is just renaming, clean-up, and reorganizing of existing api
  • the second one is the actual functionality

@VojtaStavik VojtaStavik requested review from b-onc and dmigach May 20, 2021 12:40
@codecov-commenter
Copy link

codecov-commenter commented May 20, 2021

Codecov Report

Merging #1092 (2a9282e) into main (aa9f78d) will decrease coverage by 0.01%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1092      +/-   ##
==========================================
- Coverage   91.68%   91.67%   -0.02%     
==========================================
  Files         215      216       +1     
  Lines        9121     9153      +32     
==========================================
+ Hits         8363     8391      +28     
- Misses        758      762       +4     
Flag Coverage Δ
llc-tests 91.51% <80.00%> (-0.02%) ⬇️
llc-tests-ios12 88.38% <80.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...at/Workers/Background/MissingEventsPublisher.swift 89.02% <75.00%> (-5.18%) ⬇️
...es/StreamChat/Workers/DatabaseCleanupUpdater.swift 94.64% <100.00%> (ø)
Sources/StreamChat/Utils/Logger/Logger.swift 79.74% <0.00%> (-2.54%) ⬇️
...urces/StreamChat/Database/DTOs/AttachmentDTO.swift 83.97% <0.00%> (-1.90%) ⬇️
Sources/StreamChat/Config/ChatClientConfig.swift 100.00% <0.00%> (ø)
Sources/StreamChat/Utils/MultipartFormData.swift 100.00% <0.00%> (ø)
...Chat/Models/Attachments/AnyAttachmentPayload.swift 100.00% <0.00%> (ø)
...hat/Models/Attachments/ChatMessageAttachment.swift 96.42% <0.00%> (ø)
...Models/Attachments/ChatMessageFileAttachment.swift 94.44% <0.00%> (ø)
...odels/Attachments/ChatMessageGiphyAttachment.swift 70.58% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa9f78d...2a9282e. Read the comment docs.

Copy link
Contributor

@b-onc b-onc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@VojtaStavik VojtaStavik force-pushed the CIS-858-refetch-queries-when-reconnected branch from 57a8263 to f7d57d8 Compare May 21, 2021 10:41
@VojtaStavik VojtaStavik merged commit 2e0041e into main May 21, 2021
@VojtaStavik VojtaStavik deleted the CIS-858-refetch-queries-when-reconnected branch May 21, 2021 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants