Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish UI for 4.0-beta.2 (vol.5) #1109

Merged
merged 5 commits into from May 25, 2021
Merged

Polish UI for 4.0-beta.2 (vol.5) #1109

merged 5 commits into from May 25, 2021

Conversation

nuno-vieira
Copy link
Member

@nuno-vieira nuno-vieira commented May 25, 2021 •
edited

Description of the pull request

  • Fix incorrect index path resolution for channel list
  • Fix inconsistent dismissal of popup actions
  • Make sure deletes happen before inserts on channel list changes
  • Fix dark mode of message list

@nuno-vieira nuno-vieira added the 🎨 SDK: StreamChatUI Tasks related to the StreamChatUI SDK label May 25, 2021
VojtaStavik
VojtaStavik approved these changes May 25, 2021
View reviewed changes
Copy link
Contributor

@VojtaStavik VojtaStavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Feel free to include these fixes in the changelog, too. We should start tracking the changes to UI SDK.

Sources/StreamChatUI/ChatChannelList/ChatChannelListVC.swift Show resolved Hide resolved
@nuno-vieira nuno-vieira force-pushed the Polish-UI-pre-beta-4-v5 branch 3 times, most recently from 75c7f15 to 3fdd83d Compare May 25, 2021 10:40
@VojtaStavik
Copy link
Contributor

VojtaStavik commented May 25, 2021 •
edited

@nuno-vieira I just noticed that ThreadVC background is also off

DominikBucher12
DominikBucher12 reviewed May 25, 2021
View reviewed changes
Copy link
Contributor

@DominikBucher12 DominikBucher12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a side note (probably the date indicator is not darkmode-compilant as well?)
Snímek obrazovky 2021-05-25 v 13 07 10

Snímek obrazovky 2021-05-25 v 13 06 14

@nuno-vieira
Copy link
Member Author

@nuno-vieira I just noticed that ThreadVC background is also off

Really nice catch 👍 Fixed ✅ We really need to do CIS-860

@nuno-vieira
Copy link
Member Author

nuno-vieira commented May 25, 2021 •
edited

LGTM, just a side note (probably the date indicator is not darkmode-compilant as well?)
Snímek obrazovky 2021-05-25 v 13 07 10

Snímek obrazovky 2021-05-25 v 13 06 14

Will check this 👍

Update:

@nuno-vieira nuno-vieira merged commit f4a77b5 into main May 25, 2021
@nuno-vieira nuno-vieira deleted the Polish-UI-pre-beta-4-v5 branch May 25, 2021 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evsaev evsaev evsaev left review comments

@DominikBucher12 DominikBucher12 DominikBucher12 left review comments

@VojtaStavik VojtaStavik VojtaStavik approved these changes

@skorepak skorepak Awaiting requested review from skorepak

Assignees
No one assigned
Labels
🎨 SDK: StreamChatUI Tasks related to the StreamChatUI SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nuno-vieira @VojtaStavik @evsaev @DominikBucher12