Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIS-907] Add Working with the Composer Guide #1195

Merged
merged 37 commits into from Jul 8, 2021

Conversation

nuno-vieira
Copy link
Member

@nuno-vieira nuno-vieira commented Jun 18, 2021

Description of the pull request

  • Renames the Chat Suggestions View Controller to follow the pattern across the app
  • Changes the way we were disabling the suggestions of the iMessageClone
  • Adds the guide for working with the composer

How to Test

https://stream-composer-guide.loca.lt/chat/docs/sdk/ios/guides/working-with-the-composer (In case it is offline, please ask me on Slack to put it online)

@nuno-vieira nuno-vieira added the 📋 Docs Work related to docs/wiki label Jun 18, 2021
@nuno-vieira nuno-vieira force-pushed the CIS-907-Working-with-the-composer-guide branch 3 times, most recently from 34d676e to 2e905a1 Compare June 21, 2021 15:33
Copy link
Contributor

@b-onc b-onc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good!

docusaurus/docs/iOS/guides/working-with-the-composer.md Outdated Show resolved Hide resolved
docusaurus/docs/iOS/guides/working-with-the-composer.md Outdated Show resolved Hide resolved
docusaurus/docs/iOS/guides/working-with-the-composer.md Outdated Show resolved Hide resolved
docusaurus/docs/iOS/guides/working-with-the-composer.md Outdated Show resolved Hide resolved
docusaurus/docs/iOS/guides/working-with-the-composer.md Outdated Show resolved Hide resolved
docusaurus/docs/iOS/guides/working-with-the-composer.md Outdated Show resolved Hide resolved
docusaurus/docs/iOS/guides/working-with-the-composer.md Outdated Show resolved Hide resolved
docusaurus/docs/iOS/guides/working-with-the-composer.md Outdated Show resolved Hide resolved
docusaurus/docs/iOS/guides/working-with-the-composer.md Outdated Show resolved Hide resolved
@b-onc
Copy link
Contributor

b-onc commented Jun 23, 2021

The guide should also show how to update the composer height, to show more lines (3 instead of 2), related message in slack

@nuno-vieira nuno-vieira force-pushed the CIS-907-Working-with-the-composer-guide branch from 2e905a1 to 60f42f4 Compare June 30, 2021 10:35
@Stream-iOS-Bot
Copy link
Collaborator

Stream-iOS-Bot commented Jun 30, 2021

2 Errors
🚫 Please start subject with capital letter.
0bef927
🚫 Please start subject with capital letter.
d79855b
1 Warning
⚠️ Big PR

Generated by 🚫 Danger

@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2021

Codecov Report

Merging #1195 (131da04) into main (e10c773) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1195   +/-   ##
=======================================
  Coverage   91.40%   91.40%           
=======================================
  Files         219      219           
  Lines        9419     9419           
=======================================
  Hits         8609     8609           
  Misses        810      810           
Flag Coverage Δ
llc-tests 91.24% <ø> (ø)
llc-tests-ios12 88.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e10c773...131da04. Read the comment docs.

@nuno-vieira nuno-vieira force-pushed the CIS-907-Working-with-the-composer-guide branch 6 times, most recently from 0dff854 to 08aedbd Compare July 3, 2021 01:40
Copy link
Contributor

@b-onc b-onc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really solid!

@nuno-vieira nuno-vieira force-pushed the CIS-907-Working-with-the-composer-guide branch from 962a16a to 0b54782 Compare July 8, 2021 13:16
To follow the pattern of the rest of the view controllers
Disabling the suggestions should be on the recognizing of the commands, so it does not have to do the work for nothing
This will make sure there's enough padding on the right side of the composer
@nuno-vieira nuno-vieira force-pushed the CIS-907-Working-with-the-composer-guide branch from b3673ac to e4f6ef5 Compare July 8, 2021 16:50
@nuno-vieira nuno-vieira merged commit 8f1e291 into main Jul 8, 2021
@nuno-vieira nuno-vieira deleted the CIS-907-Working-with-the-composer-guide branch July 8, 2021 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📋 Docs Work related to docs/wiki
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants