Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIS-977] Fix flickering for messages being sent #1241

Merged
merged 3 commits into from Jul 1, 2021

Conversation

evsaev
Copy link
Contributor

@evsaev evsaev commented Jul 1, 2021

This PR addresses the issue when local messages blink when reloaded because of local state changes

after.mp4

@evsaev evsaev added the 🎨 SDK: StreamChatUI Tasks related to the StreamChatUI SDK label Jul 1, 2021
@evsaev evsaev self-assigned this Jul 1, 2021
Copy link
Contributor

@VojtaStavik VojtaStavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful 😍

@evsaev evsaev force-pushed the CIS-977-local-message-flickering branch from a5ade25 to 5ea3dda Compare July 1, 2021 12:04
@codecov-commenter
Copy link

Codecov Report

Merging #1241 (a5ade25) into main (25cd277) will decrease coverage by 0.16%.
The diff coverage is n/a.

❗ Current head a5ade25 differs from pull request most recent head 5ea3dda. Consider uploading reports for the commit 5ea3dda to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1241      +/-   ##
==========================================
- Coverage   91.45%   91.29%   -0.17%     
==========================================
  Files         218      218              
  Lines        9362     9362              
==========================================
- Hits         8562     8547      -15     
- Misses        800      815      +15     
Flag Coverage Δ
llc-tests 91.29% <ø> (ø)
llc-tests-ios12 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ocketClient/Engine/StarscreamWebSocketEngine.swift 0.00% <0.00%> (-30.96%) ⬇️
.../Utils/InternetConnection/InternetConnection.swift 54.05% <0.00%> (-0.91%) ⬇️
...ources/StreamChat/Database/DatabaseContainer.swift 96.29% <0.00%> (-0.75%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25cd277...5ea3dda. Read the comment docs.

@evsaev evsaev force-pushed the CIS-977-local-message-flickering branch from 5ea3dda to 627d5fc Compare July 1, 2021 12:27
@evsaev evsaev merged commit fe61bd9 into main Jul 1, 2021
@evsaev evsaev deleted the CIS-977-local-message-flickering branch July 1, 2021 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 SDK: StreamChatUI Tasks related to the StreamChatUI SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants