New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CIS-254] Implement methods for working with invites #1276
Conversation
Generated by 🚫 Danger |
dda6d9b
to
71607e7
Compare
Codecov Report
@@ Coverage Diff @@
## main #1276 +/- ##
==========================================
- Coverage 91.42% 91.12% -0.30%
==========================================
Files 219 219
Lines 9488 9576 +88
==========================================
+ Hits 8674 8726 +52
- Misses 814 850 +36
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sources/StreamChat/Controllers/ChannelController/ChannelController.swift
Outdated
Show resolved
Hide resolved
Sources/StreamChat/Controllers/ChannelController/ChannelController.swift
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CHANGELOG and LGTM 👍
Sources/StreamChat/Controllers/ChannelController/ChannelController.swift
Show resolved
Hide resolved
2f7ce54
to
d11e23d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks 👍
Add methods for inviting a member, and for accepting/rejecting the invite.
After this change will have been merged, customers will be able to call invite/acceptInvite/rejectInvite endpoints, but they won't be able to react to events. For this to work we need changes from Pavel that introduce a mechanism for propagating events to customers' code