Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIS-254] Implement methods for working with invites #1276

Merged
merged 4 commits into from Jul 21, 2021

Conversation

dmigach
Copy link
Contributor

@dmigach dmigach commented Jul 14, 2021

Add methods for inviting a member, and for accepting/rejecting the invite.

channelController.inviteMembers(userIds: ["luke_skywalker", "leia_organa"]) { error in ... }
channelController.acceptInvite(message: "Hi everyone!") { error in ... }
channelController.rejectInvite() { error in ... }

After this change will have been merged, customers will be able to call invite/acceptInvite/rejectInvite endpoints, but they won't be able to react to events. For this to work we need changes from Pavel that introduce a mechanism for propagating events to customers' code

@Stream-iOS-Bot
Copy link
Collaborator

Stream-iOS-Bot commented Jul 14, 2021

1 Warning
⚠️ Big PR

Generated by 🚫 Danger

@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2021

Codecov Report

Merging #1276 (2f7ce54) into main (b3ebf0f) will decrease coverage by 0.29%.
The diff coverage is 76.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1276      +/-   ##
==========================================
- Coverage   91.42%   91.12%   -0.30%     
==========================================
  Files         219      219              
  Lines        9488     9576      +88     
==========================================
+ Hits         8674     8726      +52     
- Misses        814      850      +36     
Flag Coverage Δ
llc-tests 91.12% <76.92%> (-0.14%) ⬇️
llc-tests-ios12 91.12% <76.92%> (+2.98%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...t/APIClient/Endpoints/Payloads/MemberPayload.swift 100.00% <ø> (ø)
Sources/StreamChat/Query/ChannelQuery.swift 100.00% <ø> (ø)
...at/WebSocketClient/Events/NotificationEvents.swift 64.28% <0.00%> (-25.72%) ⬇️
.../StreamChat/WebSocketClient/Events/EventType.swift 92.30% <50.00%> (-7.70%) ⬇️
...trollers/ChannelController/ChannelController.swift 92.23% <75.00%> (-0.87%) ⬇️
...eamChat/APIClient/Endpoints/ChannelEndpoints.swift 100.00% <100.00%> (ø)
...rces/StreamChat/Database/DTOs/MemberModelDTO.swift 100.00% <100.00%> (ø)
Sources/StreamChat/Workers/ChannelUpdater.swift 98.11% <100.00%> (+0.17%) ⬆️
...ocketClient/Engine/StarscreamWebSocketEngine.swift 0.00% <0.00%> (-30.96%) ⬇️
.../Utils/InternetConnection/InternetConnection.swift 54.05% <0.00%> (-0.91%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3ebf0f...2f7ce54. Read the comment docs.

@dmigach dmigach requested a review from evsaev July 16, 2021 12:55
@dmigach dmigach marked this pull request as ready for review July 20, 2021 09:26
Copy link
Contributor

@evsaev evsaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHANGELOG and LGTM 👍

@evsaev evsaev self-requested a review July 21, 2021 09:00
Copy link
Contributor

@evsaev evsaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks 👍

@dmigach dmigach merged commit 3567348 into main Jul 21, 2021
@dmigach dmigach deleted the CIS-254-implement-invites branch July 21, 2021 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants