[CIS-1153] Fix an issue with thread replies not being shown if there was a reply that was also sent to a channel #1413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… that was also sent to the channel
dmigach
force-pushed
the
CIS-1153-thread-replies-fix
branch
from
a270820
to
e54bef3
Compare
tbarbugli
approved these changes
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An issue was reported here:
#1389
It's easily reproducible with the local storage disabled, but when it disabled the behaviour is also not entirely correct
What's happening:
If there was a thread reply that was also sent to the channel, you get it when you fetch the channel. Then when you open the original thread, this problematic reply is in core data already, so
replies.lastwon't return nil, even though the only reply in this collection has nothing to do with the last message. So we would take thisreplies.lastreply and use it to start our pagination with, ignoring all the messages that are younger